multimedia/kbtv: broken saa kmod?

[Danny Pansters]

I don't see this happening but I did get other (casting) errors that gcc calls 
warnings. Start with a fresh make extract then put the attached diffs in 
kbtv_wrksrc_dir/saa/patches/

This makes it build for me on both amd64 and i386 (on STABLE). I haven't 
crawled under my desk yet and switched the TV card to my AMD box so I can 
only say that it compiles on amd (amd64 native, not in 32 bits mode I don't 
use that at all).

It doesn't contain any secam support yet either (I'll probably do that in my 
own saa.c module).

HTH,

Dan

> On Tue, 13 Feb 2007 06:09:13 +0300 Yuri Pankov wrote:
> > I've attached a patch allowing saa kmod to compile cleanly on amd64 with
> > WERROR defined.
>
> Thanks, Yuri, pathces applied cleanly. But while compiling I get:
> -----
> ===> kmod (all)
> Warning: Object directory not changed from original
> /usr/ports/multimedia/kbtv/work/kbtv-1.2.3/saa/saa/kmod @ -> /usr/src/sys
> machine -> /usr/src/sys/amd64/include
> awk -f @/tools/makeobjops.awk @/dev/iicbus/iicbus_if.m -h
> awk -f @/tools/makeobjops.awk @/kern/device_if.m -h
> awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h
> awk -f @/tools/makeobjops.awk @/dev/pci/pci_if.m -h
> cc -O2 -fno-strict-aliasing -pipe  -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> -I-   -I. -I@ -I@/contrib/altq -I@/../include -I/usr/include
> -finline-limit=8000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel
> -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow 
> -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes 
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual 
> -fformat-extensions -std=c99 -c saa713x.c cc -O2 -fno-strict-aliasing -pipe
>  -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I-   -I. -I@ -I@/contrib/altq
> -I@/../include -I/usr/include -finline-limit=8000 -fno-common 
> -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387
> -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float
> -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls
> -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith
> -Winline -Wcast-qual  -fformat-extensions -std=c99 -c saa713x_i2c.c
> saa713x_i2c.c:157: error: conflicting types for 'saa_i2c_write'
> ./saa713x_i2c.h:32: error: previous declaration of 'saa_i2c_write' was here
> saa713x_i2c.c:157: error: conflicting types for 'saa_i2c_write'
> ./saa713x_i2c.h:32: error: previous declaration of 'saa_i2c_write' was here
> *** Error code 1
>
> Stop in /usr/ports/multimedia/kbtv/work/kbtv-1.2.3/saa/saa/kmod.
> *** Error code 1
>
> Stop in /usr/ports/multimedia/kbtv/work/kbtv-1.2.3/saa/saa.
> -----
>
> Help me! ;-)
>
>
> WBR