multimedia/kbtv: broken saa kmod?

[Yuri Pankov]

On Mon, Feb 12, 2007 at 09:45:19PM +0100, Danny Pansters wrote:
> On Monday 12 February 2007 18:59, Boris Samorodov wrote:
> > Hi,
> >
> >
> > just noticed that kbtv is being developed. Greate news, thanks!
> >
> > Did somebody manage to build saa kernel module (multimedia/kbtv)? I've
> > got an error:
> > -----
> > ===> kmod (all)
> > Warning: Object directory not changed from original
> > /usr/ports/multimedia/kbtv/work/kbtv-1.2.3/saa/saa/kmod @ -> /usr/src/sys
> > machine -> /usr/src/sys/amd64/include
> > awk -f @/tools/makeobjops.awk @/dev/iicbus/iicbus_if.m -h
> > awk -f @/tools/makeobjops.awk @/kern/device_if.m -h
> > awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h
> > awk -f @/tools/makeobjops.awk @/dev/pci/pci_if.m -h
> > cc -O2 -fno-strict-aliasing -pipe  -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> > -I-   -I. -I@ -I@/contrib/altq -I@/../include -I/usr/include
> > -finline-limit=8000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel
> > -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow 
> > -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall
> > -Wredundant-decls -Wnested-externs -Wstrict-prototypes 
> > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual 
> > -fformat-extensions -std=c99 -c saa713x.c saa713x.c: In function
> > `saa_build_pta':
> > saa713x.c:507: warning: int format, different type arg (arg 2)
> 
> Looks like it needs a cast, might be an easy fix.
> 
> > *** Error code 1
> >
> > Stop in /usr/ports/multimedia/kbtv/work/kbtv-1.2.3/saa/saa/kmod.
> > *** Error code 1
> >
> > Stop in /usr/ports/multimedia/kbtv/work/kbtv-1.2.3/saa/saa.
> > -----
> >
> > # make -V PORTVERSION
> > 1.2.3
> > # uname -a
> > FreeBSD srv.sem.ipt.ru 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Jan 15
> > 17:30:44 MSK 2007     bsam at srv.sem.ipt.ru:/usr/obj/usr/src/sys/GENERIC 
> 
> > amd64
> 
> Ah, I'm on i386, I've seen something similar before. The 64 bit platforms are 
> more picky. I'll see what I can do (I have an amd64 box to test on).
> 
> Thanks,
> 
> Dan
> 
> 
> PS
> 
> I see you are Russian; I'm not sure if it applies to you, but please note that 
> secam doesnt work, only pal d/k/L' (whichever you may need). You'd probably 
> get black-and-white video and no sound. While it may be easy to add the 
> needed audio carrier frequencies (if provided with the correct values) in my 
> own code, the handling of secam video in the saa driver may be harder 
> considering that I can't really test. It may be possible to deal with it in 
> my own code while rendering, and do a conversion there but that will probably 
> be slow. It would be great if someone would just sent me a secam patch :)

Hi,

I've attached a patch allowing saa kmod to compile cleanly on amd64 with WERROR
defined.

I don't use kbtv but am interested in saa713x driver, so improvements to make it
work in SECAM are welcome. Just setting SECAM video standard to get colour picture
seems pretty easy, given the code in saa/saa/support/set_videoopt.c. Diff adding
SECAM option to it is also attached.

Another question - is anyone successfully running this driver on -CURRENT? I'm 
wondering cause of the following change by imp@ to iicbus.c, denying attach of 
generic iic device:

===================================================================
RCS file: /usr/local/www/cvsroot/FreeBSD/src/sys/dev/iicbus/iicbus.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -p -r1.21 -r1.22

<snip>

@@ -139,51 +139,52 @@ iicbus_attach(device_t dev)
 	printf("\n");
 #endif
   
-	/* attach any known device */
 	device_add_child(dev, "ic", -1);
-	device_add_child(dev, "iic", -1);
 	device_add_child(dev, "iicsmb", -1);
-
+#if 0
+	/* attach any known device */
+	device_add_child(dev, "iic", -1);
+#endif         
 	bus_generic_attach(dev);
-         
         return (0);
 }

<snip>


HTH,
Yuri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: saa-kmod.diff
Type: text/x-diff
Size: 5786 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20070213/8454acd0/saa-kmod.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: set_videoopt.c.diff
Type: text/x-diff
Size: 1115 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20070213/8454acd0/set_videoopt.c.bin