FreeBSD Port: horde-base-3.1.5_1

[Beech Rintoul]

On Wednesday 19 December 2007, Jeremy Chadwick said:
> On Wed, Dec 19, 2007 at 02:29:40PM -0000, Barry Byrne wrote:
> > > -----Original Message-----
> > > From: Jeremy Chadwick [mailto:koitsu at FreeBSD.org]
> > > Sent: 19 December 2007 11:34
> > > To: Barry Byrne
> > > Cc: beech at FreeBSD.org; ports at FreeBSD.org;
> > > hiromi at tac.tsukuba.ac.jp; ache at freebsd.org; perky at freebsd.org
> > >
> > > > Checked the patched file (NLS.php) and I had something like
> > > > this;
> > > >
> > > >  \xa0 \xa0 \xa0 \xa0/* avoid FreeBSD issapce(3) bug */
> > > >  \xa0 \xa0 \xa0 \xa0if(NLS::getCharset() == "UTF-8"){
> > > >  \xa0 \xa0 \xa0 \xa0 \xa0 \xa0setlocale(LC_CTYPE,"C");
> > > >  \xa0 \xa0 \xa0 \xa0}
> > > >
> > > > When I replaced the \xa0 with tabs, all was fine again.
> > >
> > > The parse error is probably because PHP does not have Unicode
> > > or multibyte character support enabled.  The patch file in
> > > question contains actual Unicode characters.  You might try
> > > rebuilding PHP with Zend support for multibyte characters (it's
> > > an option in "make config")
> > > and see if that improves things.
> >
> > Jeremy,
> >
> > Thanks for the quick response.
> >
> > You're correct in assuming I don't have Multibyte enabled.
> >
> > However, I just rebuilt php on another machine and enabled
> > multibyte, then built horde-base on that, but still had the same
> > characters in the NLS.php file on that, so not sure what the
> > problem is.
>
> Okay, so it's probably a Unicode vs. UTF-8 parser thing.
>
> My comment about the code needing to remain in ASCII stands, though
> (this isn't your fault, of course).  The patch should really be
> fixed to use literal whitespace (ASCII 0x20) or tabs (ASCII 0x09).
>
> I have commit access to fix this, but I want to clear it + discuss
> with those involved with the PR first.

I have re-rolled the patch, please let me know if you still have 
problems. It may take a while to get into the tree.

Beech

-- 
---------------------------------------------------------------------------------------
Beech Rintoul - FreeBSD Developer - beech at FreeBSD.org
/"\   ASCII Ribbon Campaign  | FreeBSD Since 4.x
\ / - NO HTML/RTF in e-mail   | http://www.freebsd.org
 X  - NO Word docs in e-mail | Latest Release:
/ \  - http://www.FreeBSD.org/releases/6.2R/announce.html
---------------------------------------------------------------------------------------