serious error possibly related to bsd.*.mk

[Andriy Gapon]

on 13/12/2007 15:56 Dirk Meyer said the following:
> Hallo Andriy Gapon,
>> Here's diff between old and new options just in case:
>> --- /tmp/options        Mon May 21 11:12:22 2007
>> +++ /var/db/ports/graphviz/options      Thu Dec 13 14:27:03 2007
>> @@ -1,12 +1,18 @@
>>  # This file is auto-generated by 'make config'.
>>  # No user-servicable parts inside!
>> -# Options for graphviz-2.12_2
>> -_OPTIONS_READ=graphviz-2.12_2
>> +# Options for graphviz-2.16
>> +_OPTIONS_READ=graphviz-2.16
>>  WITH_TK=true
>>  WITH_XPM=true
>>  WITH_ICONV=true
>>  WITH_NLS=true
>>  WITH_PANGOCAIRO=true
>> +WITH_GTK=true
>> +WITHOUT_GDK_PIXBUF=true
>> +WITH_GNOMEUI=true
>> +WITHOUT_DIGCOLA=true
>> +WITHOUT_IPSEPCOLA=true
>> +WITHOUT_MING=true
>>  WITH_PERL=true
>>  WITHOUT_PHP=true
>>  WITH_PYTHON=true
> 
> That is very strange.
> I habe no idea yet why this fails.

I noticed that if comment out WITH_GTK in the options file or turn off
GTK option via 'make config' (so that it becomes WITHOUT_GTK) then the
problem comes back. So there must be something 'magic' about it.

Hmm, if I comment out the following lines:
.if defined(WITH_GTK)
.include "${PORTSDIR}/Mk/bsd.gnome.mk"
.endif

Then I also get the error:
"/usr/ports/Mk/bsd.gnome.mk", line 643: Malformed conditional
(${_USE_GNOME_ALL:Mpango}=="")
"/usr/ports/Mk/bsd.gnome.mk", line 643: Malformed conditional
(${_USE_GNOME_ALL:Mgtk20}=="")
"/usr/ports/Mk/bsd.gnome.mk", line 643: Malformed conditional
(${_USE_GNOME_ALL:Mlibgnomeui}=="")

So it seems that in this case bsd.gnome.mk still gets sucked in but in
some improper way. This probably happens when 'IGNORE' should have
became active i.e. GTK is off but something depending on it is on.

Having though about it - maybe this is because USE_GNOME becomes defined
so bsd.gnome.mk get included via bsd.port.mk (via bsd.port.post.mk, in
turn).
I think there could be two solutions: either not set USE_GNOME unless
WITH_GTK is defined or add "or" case for USE_GNOME before inclusion of
bsd.gnome.mk. Or even include it unconditionally.

-- 
Andriy Gapon