Weird problem with shells/scponly

[Nikola Lecic]

On Fri, 24 Aug 2007 13:59:10 -0500
Paul Schmehl <pauls at utdallas.edu> wrote:

> --On Friday, August 24, 2007 21:24:37 +0400 Yuri Pankov 
> <yuri at darklight.org.ru> wrote:
> 
> > On Fri, Aug 24, 2007 at 12:13:16PM -0500, Paul Schmehl wrote:
> >> I just encountered a very strange problem with shells/scponly.
> >> When I tried to portupgrade it, I consistently got an error:
> >>
> >> /usr/ports/shells/scponly]# portupgrade scponly*
> >> --->  Upgrading 'scponly-4.6_1' to 'scponly-4.6_2' (shells/scponly)
> >> --->  Building '/usr/ports/shells/scponly' with make flags:
> >> WITH_SCPONLY_WINSCP
> >> make: don't know how to make WITH_SCPONLY_WINSCP. Stop
> >> ** Listing the failed packages (*:skipped / !:failed)
> >>        ! shells/scponly (scponly-4.6_1)        (clean error)
> >> --->  Packages processed: 0 done, 0 ignored, 0 skipped and 1 failed
> >>
> >> That option wasn't selected and isn't selected by default.  I
> >> tried make rmconfig/make config, and all the other tricks I know,
> >> including make distclean/portupgrade scponly*.
> >>
> >> Finally I deinstalled the port and reinstalled it.  It installs
> >> fine both  with and without that knob.
> >>
> >> Is portupgrade saving some setting somewhere that is different from
> >> config?
> >>
> >> (I've cc'd the port maintainer although it doesn't look like
> >> there's a problem with the port itself.)
> >>
> >> --
> >> Paul Schmehl (pauls at utdallas.edu)
> >> Senior Information Security Analyst
> >> The University of Texas at Dallas
> >> http://www.utdallas.edu/ir/security/
> >
> > It's only a make flag and is passed to make as it is. You need to
> > define it using -DWITH_SCPONLY_WINSCP or by assigning some value to
> > it: WITH_SCPONLY_WINSCP=yes. In your case it was treated as make
> > target, hence error message.
> >
> Yes, but the point is, I *wasn't* trying to build with that flag
> *and* it wasn't *supposed* to build with that flag.  Yet it was
> trying to (and failing) anyway.  The default value of the OPTION is
> "off", and I didn't turn it on.

The point of this line

  --->  Building '/usr/ports/shells/scponly' with make flags:
        WITH_SCPONLY_WINSCP

is that this message occurs only if you use --make-args or if you
define something in /usr/local/etc/pkgtools.conf.

'Building ... with make flags...' message _doesn't_ appear if you have
saved/changed options in /var/db/ports (this is indicated with "Found
saved configuration...". I reproduced your error like this:

  nyx# portupgrade -f -m 'WITH_SCPONLY_WINSCP' scponly
  --->  Reinstalling 'scponly-4.6_2' (shells/scponly)
  --->  Building '/usr/ports/shells/scponly' with make flags: WITH_SCPONLY_WINSCP
  make: don't know how to make WITH_SCPONLY_WINSCP. Stop
  ** Listing the failed packages (*:skipped / !:failed)
          ! shells/scponly (scponly-4.6_2)        (clean error)
  --->  Packages processed: 0 done, 0 ignored, 0 skipped and 1 failed

So, 'WITH_SCPONLY_WINSCP' somehow leaked into make_args of the
portupgrade script -- and you can easily find where. Do you use
portupgrade-devel?

Nikola Lečić