Generating INDEX

Gerald Pfeifer gerald at
Fri Apr 13 22:32:22 UTC 2007

On Fri, 13 Apr 2007, Rong-en Fan wrote:
> No, the patch won't work. According to
> the right way is always define WANT_GNOME which won't pull
> any gnome dependencies unless USE_GNOME is used.
> I think after USE_PERL5_BUILD line, add
> and use += for USE_GNOME after

Thanks.  This matches my reading of as well, so I committed
the patch at the end of this message to hopefully address the breakage.

On Fri, 13 Apr 2007, Pav Lucistnik wrote:
>> I think after USE_PERL5_BUILD line, add
>> and use += for USE_GNOME after
> The usual workaround is
> USE_GNOME=	# empty
> .include <>
> USE_GNOME+=	foo bar baz

What Rong-en proposed matches my reading of our GNOME porting 
documentation, and according to my reading of your 
proposal is just another way of achieving the same result.  Is
this correct?

What worries me more is that the same documentation also has:

  Note: You cannot add extra default USE_GNOME components after the 
  .include <>. That is, the following is wrong :

  .include <>

  .if ${HAVE_GNOME:Mgnomelibs}!=""
      USE_GNOME+= libgnome
      USE_GNOME+= gtk12  # WRONG!
and lang/gcc41 has the following right now after .include 

  USE_GNOME=    gtk20 libartlgpl2

Should we move the USE_GNOME=gtk20 part into lang/gcc41-withgcjawt
and only keep USE_GNOME+=libartlgpl2 at this point in lang/gcc41 or
is the current use okay in this specific setting?


PS: For now I committed the patch below which ought to be correct in
any case.  I won't be able to be online too much over the weekend, so
if any of you please be more than welcome to apply any followup patch
as needed if you are confident it is the right thing to do.

Index: Makefile
RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v
retrieving revision 1.318
diff -u -3 -p -r1.318 Makefile
--- Makefile	10 Apr 2007 05:24:27 -0000	1.318
+++ Makefile	13 Apr 2007 22:06:51 -0000
@@ -34,6 +34,7 @@ USE_BZIP2=	yes

More information about the freebsd-ports mailing list