Help with makefile options

[Beech Rintoul]

I submitted an update and the comitter didn't like the way options were 
defined. He said:

>  On Wednesday 17 May 2006 03:56, you wrote:
>  > Could you please check the way you use OPTIONS against the respective
>  > PH chapter ? (check "on" options against WITHOUT and "off" against WITH)
>  > (I don't think you actually break something because the "bug" mentioned
>  > there only affects make depend /describe, but let's be consistent).

"Due to a deficiency in the infrastructure, you can only test WITH_*
variables for options, which are OFF by default, and WITHOUT_*
variables for options, which defaults to ON"

And an example:

OPTIONS=        IPV6 "Use IPv6" off \
.if defined(WITH_IPV6)
.if defined(WITHOUT_IPV6)
second .if should be: ,if !defined(WITH_IPV6)

 > grep IFSESSION Makefile
                IFSESSION "Include mod_ifsession" on \
.if defined(WITH_IFSESSION)
should be .if !defined(WITHOUT_IFSESSION)

How would this work? It looks to me like they would be defined as opposite of 
what they are intended to do. Could someone explain this to me? I seem to be 
missing something.

Beech

-- 

---------------------------------------------------------------------------------------
Beech Rintoul - Sys. Administrator - beech at alaskaparadise.com
/"\   ASCII Ribbon Campaign  | Alaska Paradise
\ / - NO HTML/RTF in e-mail  | 201 East 9Th Avenue Ste.310
 X  - NO Word docs in e-mail | Anchorage, AK 99501
/ \  - Please visit Alaska Paradise - http://www.alaskaparadise.com
---------------------------------------------------------------------------------------











-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20060517/497d4fb3/attachment.pgp