opendx "make install" fails: typo in Makefile ?

[Vasil Dimov]

On Tue, Mar 14, 2006 at 11:21:57PM -0800, Rob wrote:
> 
> Hi,
> 
> The Makefile in /usr/ports/graphics/opendx has
> these lines at different linenumbers:
> 
> 62:DIR2PRUNE=  dx/java/user dx/java/server/nets
> 91:${TOUCH} ${DIR2PRUNE:S|^|${PREFIX}/|:S|$|/.keepme|}
> 99:${RMDIR} ${DIR2PRUNE:S|^|${PREFIX}/}
> 
> Are these lines correct? The error below has a
> message about "| missing".
> 
> The result seems to depend on whether "WITHOUT_JAVA"
> is defined or not. I myself use "WITHOUT_JAVA=YES".
> 
> The "make" of opendx is alright, however the
> "make install" fails with:
> 
> # make install
> [...snip...]
> gmake[1]: Leaving directory
> `/usr/ports/graphics/opendx/work/dx-4.4.0'
> Unclosed substitution for DIR2PRUNE (| missing)
> *** Error code 2
> 
> Stop in /usr/ports/graphics/opendx.
> ** Command failed [exit code 1]: /usr/bin/script -qa
> /tmp/portinstall14079.0 make reinstall
> ** Fix the installation problem and try again.
> 
> 
> ----
> 
> Ideas how to fix this?
> 

Syntactically speaking ${DIR2PRUNE:S|^|${PREFIX}/} is wrong
and should be ${DIR2PRUNE:S|^|${PREFIX}/|}, but in this exact case
the rmdir command is not necessary at all.
I just committed a fix, thanks for spotting this!

-- 
Vasil Dimov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 155 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20060315/a4a39983/attachment.pgp