RFC: bsd.sites.mk - introduce some magic

Shaun Amott shaun at FreeBSD.org
Wed Jul 26 15:11:22 UTC 2006


On Wed, Jul 26, 2006 at 03:37:37PM +0100, Florent Thoumie wrote:
> On Wed, 2006-07-26 at 17:18 +0400, Andrew Pantyukhin wrote:
> > 
> > 1. (A tad) cleaner ports Makefiles:
> > Write MASTER_SITES=FOOBAR instead of
> > MASTER_SITES=${MASTER_SITE_FOOBAR} and get away
> > with it
> > 
> > 2. Abbreviations
> > Write MASTER_SITES=SF and mean SOURCEFORGE
> 
> I don't quite like having 3 different ways to use a group of
> MASTER_SITES.

Agreed - the above changes are gratuitous, and simply add an unnecessary
layer of obfustication. It also seems strange to pick out one or two
MASTER_SITES sets only.

> > 3. Default subdirs
> > With MASTER_SITES set to SF or SOURCEFORGE you
> > get MASTER_SITE_SUBDIR?=${PORTNAME:L} for free!
> 
> This is a really good thing.

I agree.

-- 
Shaun Amott [ PGP: 0x6B387A9A ]
    Scientia Est Potentia.


More information about the freebsd-ports mailing list