ports/86310: [patch] all-depends-list target of bsd.port.mk is buggy

[Kris Kennaway]

On Sat, Jan 28, 2006 at 05:06:53PM -0500, Mikhail Teterin wrote:
> Actually, I think, this is an even better fix:
> 
> --- bsd.port.mk	23 Jan 2006 22:29:26 -0000	1.523
> +++ bsd.port.mk	28 Jan 2006 22:06:23 -0000
> @@ -4582,5 +4582,5 @@
>  
>  _UNIFIED_DEPENDS=${EXTRACT_DEPENDS} ${PATCH_DEPENDS} ${FETCH_DEPENDS} 
> ${BUILD_DEPENDS} ${LIB_DEPENDS} ${RUN_DEPENDS} ${PERL_BUILD_DEPENDS} 
> ${PERL_RUN_DEPENDS}
> -_DEPEND_DIRS=	${_UNIFIED_DEPENDS:C,^[^:]*:([^:]*),\1,} ${DEPENDS:C,:.*,,}
> +_DEPEND_DIRS=	${_UNIFIED_DEPENDS:C,^[^:]*:([^:]*).*$,\1,} ${DEPENDS:C,:.*,,}

I have discovered a related problem, which is that when a :target is
specified e.g. in PATCH_DEPENDS, it does not correctly recurse to
discover the necessary dependencies.  e.g. the cups-magicolor port has

PATCH_DEPENDS=  ${NONEXISTENT}:${PORTSDIR}/print/cups-base:configure

but the only patch dependency added is 

(ports-i386:~/7/ports/print/cups-magicolor)> make describe | cut -f 9 -d \|
/var/portbuild/i386/7/ports//print/cups-base

when it should go and add all the build dependencies of cups-base
(e.g. gmake), and their runtime dependencies (libiconv, etc).

I'd really appreciate if you could work on this too.  For now the only
workaround is to explicitly add the full dependency list to the
affected ports by hand.

Kris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20060131/9ca7ac98/attachment.bin