Flaw in print/acroread7 (was: Re: [ru@FreeBSD.org: [patch] mixed i386/amd64 ports semi-broken])

[Kris Kennaway]

On Mon, Jan 30, 2006 at 07:18:41AM +0100, Jean-Yves Lefort wrote:

> > I don't see your point.  The line Ruslan is removing clearly must do
> > something, otherwise it can't "fix" the affected ports.  If it does
> > something, it needs to be shown that it doesn't do something bad.
> 
> The line Ruslan is removing is a performance improvement; its purpose
> is to remove the need to execute uname -p in submakes.

OK, that sounds like "something bad" to start with.  What is the time
impact on 'make index'?

> But since it
> passes ARCH as a make argument, it breaks things such as:
> 
> .if (${ARCH} == "amd64")
> ARCH=           i386
> RPMFLAGS+=      --ignorearch
> .endif

How many ports do that?

> because the ARCH=i386 assignment is overriden by the ARCH passed on
> the submake command line. Removing ARCH from .MAKEFLAGS should fix the
> issue without breaking ports.

Perhaps you can just do the same thing, and pass in the new ARCH to
the port build as a make argument.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20060130/32bde5a7/attachment.bin