cvs commit: ports/mail/dk-milter Makefile pkg-plist ports/mail/dk-milter/files milter-dk.sh.in

[Brooks Davis]

On Tue, Jan 17, 2006 at 11:45:43AM +0100, Pav Lucistnik wrote:
> Sam Lawrance pí?e v út 17. 01. 2006 v 21:39 +1100:
> > Over to ports@ ...
> > 
> > On 17/01/2006, at 10:50 AM, Doug Barton wrote:
> > 
> > > Pav Lucistnik wrote:
> > >> pav         2006-01-15 09:11:04 UTC
> > >>
> > >>   FreeBSD ports repository
> > >>
> > >>   Modified files:
> > >>     mail/dk-milter       Makefile pkg-plist
> > >>     mail/dk-milter/files milter-dk.sh.in
> > >>   Log:
> > >>   - Convert RC script to rc_subr
> > >>
> > >>   PR:             ports/91595  http://www.FreeBSD.org/cgi/query- 
> > >> pr.cgi?pr=91595
> > >>   Submitted by:   Hirohisa Yamaguchi <umq at ueo.co.jp>
> > >>
> > >>   Revision  Changes    Path
> > >>   1.6       +3 -2      ports/mail/dk-milter/Makefile
> > >>   1.2       +43 -48    ports/mail/dk-milter/files/milter-dk.sh.in
> > >>   1.2       +0 -1      ports/mail/dk-milter/pkg-plist
> > >>
> > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/ 
> > >> Makefile.diff?&r1=1.5&r2=1.6&f=h
> > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/files/ 
> > >> milter-dk.sh.in.diff?&r1=1.1&r2=1.2&f=h
> > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/pkg- 
> > >> plist.diff?&r1=1.1&r2=1.2&f=h
> > >
> > > It's not a big enough issue to warrant a change for this port, but in
> > > general it's a good idea if the name of the rc.d file is the same  
> > > as what
> > > the script PROVIDE's. This removes one potential source of  
> > > confusion for users.
> > 
> > Is it worth a patch to portlint?  There are probably a stack of other  
> > rc-related things that could be checked for, too.  For example, if an  
> > rc script is in the packing list, warn to use USE_RC_SUBR.  Others?
> 
> If an rc.d script is in the packing list! Old styled scripts are not
> affected. How will you check that from portlint?

You use grep to see if they match the rules currently used in /etc/rc
and /etc/rc/localpkg.  Any file which is not an rc.d script, should
generate a warning because we plan to fully remove support for old style
scripts and non-execution of .sample scripts at some time in the future
(my guess would be 8.0).  Portlint should also warn about any .sh
scripts installed into rc.d since their behavior will change to being
sourced with ". <script>" just like the base once we get everything
cleaned out and have given users sufficient time to upgrade.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20060117/931809fa/attachment.bin