Enforcing "DIST_SUBDIR/DISTFILE" uniqueness

Andrew Pantyukhin infofarmer at FreeBSD.org
Sun Aug 20 09:08:44 UTC 2006


On 8/20/06, Andrew Pantyukhin <infofarmer at freebsd.org> wrote:
> On 8/20/06, Doug Barton <dougb at freebsd.org> wrote:
> > OTOH, your solution would break the logic that portmaster (and I believe
> > portupgrade also) uses to detect and delete stale distfiles.
>
> AFAICT portmaster's logic still misses the case when
> DIST_SUBDIR has changed for whatever reason.

Oh, now that I've had another look at portmaster's logic it
doesn't makes sense at all. What if distfiles of different
ports have similar %[-_]* names? What if different ports
require the same distfile of different versions? What if
distname changed radically? You can't make such broad
assumptions about distfile patterns. You should probably
do it the same way portsclean -D does - i.e. to check
"dist_subdir/distfile" against distinfo files of all installed
ports or all ports, whichever a user prefers.


More information about the freebsd-ports mailing list