Strange portlint error

[Jeremy Messenger]

On Thu, 21 Jul 2005 21:39:44 -0500, Paul Schmehl <pauls at utdallas.edu>  
wrote:

> I just ran portlint on a new port I'm working on, and I got the  
> following error:
>
> portlint -N
> WARN: Makefile: COMMENT should begin with a capital, and end without a  
> period

Read here, it said 'end without a period'.

> 0 fatal errors and 1 warnings found.
>
> Here's the comment:
>
> COMMENT=        Squil is a network security management program.
>
> As you can see, it has a period.  If I remove the period, portlint  
> returns "looks fine".

That's expect behavior.

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-comment.html

Cheers,
Mezz

> Line 2054 of portlint reads:
>
> if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} =~  
> m/\.$/)) { #"
>
> It should be:
>
> if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} !~  
> m/\.$/)) { #"
>
> This patch will fix it:
>
> --- portlint.orig       Thu Jul 21 21:40:24 2005
> +++ portlint    Thu Jul 21 21:38:46 2005
> @@ -2050,7 +2050,7 @@
>                 &perror("WARN: $file: unless this is a master port,  
> COMMENT has to be set by \"=\", ".
>                         "not by \"$1=\".") unless ($masterport);
>         } else { # check for correctness
> -               if (($makevar{COMMENT} !~ /^["0-9A-Z]/) ||  
> ($makevar{COMMENT} =~ m/\.$/)) { #"
> +               if (($makevar{COMMENT} !~ /^["0-9A-Z]/) ||  
> ($makevar{COMMENT} !~ m/\.$/)) { #"
>                         &perror("WARN: $file: COMMENT should begin with  
> a capital, and end without a period");
>                 } elsif (length($makevar{COMMENT}) > 70) {
>                         &perror("WARN: $file: COMMENT exceeds 70  
> characters limit.");
>
> Paul Schmehl (pauls at utdallas.edu)
> Adjunct Information Security Officer
> University of Texas at Dallas
> AVIEN Founding Member
> http://www.utdallas.edu/


-- 
mezz7 at cox.net  -  mezz at FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome at FreeBSD.org