FreeBSD Port: qmail-1.03_3
Joe Marcus Clarke
marcus at marcuscom.com
Tue Jan 25 17:55:34 PST 2005
On Tue, 2005-01-25 at 17:36 -0800, Michael Sierchio wrote:
> You have added a patch which is totally unneccesary, and I
> suggest that it be removed:
> in your patch-qmail-local....
> - while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t'))
> + while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t')))
> This is totally bogus, the original code is correct. Please do not
> make changes to contributed code simply because it makes it easier
> for you to understand. There is no semantic difference between the
> two, ERGO the patch should not exist. Please remove it.
Actually, if k is less than or equal to i and cmds.s[k-1] is a tab, then
the first bit of code evaluates to true while the second evaluates to
false. I haven't looked at the rest of the code, but those statements
are semantically different, and I think the second is more correct.
> Shall I file a PR?
> - Michael
> freebsd-ports at freebsd.org mailing list
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe at freebsd.org"
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20050125/faf575c9/attachment.bin
More information about the freebsd-ports