FreeBSD Port: qmail-1.03_3
kudzu at tenebras.com
Tue Jan 25 17:36:51 PST 2005
You have added a patch which is totally unneccesary, and I
suggest that it be removed:
in your patch-qmail-local....
- while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t'))
+ while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t')))
This is totally bogus, the original code is correct. Please do not
make changes to contributed code simply because it makes it easier
for you to understand. There is no semantic difference between the
two, ERGO the patch should not exist. Please remove it.
Shall I file a PR?
More information about the freebsd-ports