<sys/select.h> depends on <sys/types.h>...?

[Michael Nottebrock]

Chuck Swiger wrote:


>> If you go back a few linux kernel/solaris/macosx releases, you'd 
>> probably find the extra include requirement there, too.
> 
> 
> Sure.  Only, if an earlier version of Linux 2.2 or OS X needed 
> sys/types.h to use sys/select.h, then wouldn't the BZFlag sources know 
> to use it by now...?

Portability issues in upstream sources don't get fixed because they exist - 
they need to be reported and fixes need to be accepted and applied, too.

The code in question exists in bzflag since 2003. The FreeBSD port of bzflag 
exists since 2000, an OpenBSD port, with patch, exists since 2003. NetBSD's 
pkgsrc patches the file for FreeBSD 4.x's sake, too. How could this issue ever 
have survived in the upstream sources? - Easily. :-)

*idly wonders how many

+#ifdef HAVE_SYS_TYPES_H
+#include <sys/types.h>
+#endif

will need to be added to KDE 3.4 to make it compile on 4.x*

-- 
    ,_,   | Michael Nottebrock               | lofi at freebsd.org
  (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
    \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org