WITHOUT_X11 knob for mplayer

[Florent Thoumie]

Jeremie Le Hen wrote:

> Hi,
> 
> I'm using mplayer as an MP3 mplayer on a small computer on which I don't
> want to install any graphical interface.  Thus I added the WITHOUT_X11
> knob for the mplayer port.  The patch is attached.  Note that I added
> an explicit dependency on imake in this case since mplayer requires it
> to build.

	You should consider using USE_IMAKE=yes rather than adding imake-6
	to BUILD_DEPENDS, since imake-6 is assuming that everyone uses xorg
	as X_WINDOW_SYSTEM.

> Does this make sense to you to have this knob ?  I don't think it's a
> great deal anyway, the default behaviour stays unchanged.  Should I
> submit a PR for this (and get it lost for months ;-) ) ?

	You can send a PR if you have no answer from the actual maintainer.
	BTW, it's often a good idea to send a PR, to keep a track :)

-- 
Florent Thoumie
flz at xbsd.org