broken port: gnuchess

[Conrad J. Sabatier]

OK, I figured out what the problem was.

The "DISTFILES+=" line was not behaving as one would expect.  Rather
than appending to the default (implicitly declared) DISTFILES set of
"gnuchess-5.0.7.tar.gz", it winds up being the *only* member of the
DISTFILES set (have we stumbled across a bug in the ports build system,
perhaps?).  Running 'portlint -v' reveals this to be true.

Edwin, do you want me to just send you a diff against the Makefile, or
against the whole port?  Actually, it's really such a very minor fix,
perhaps you could just do it yourself by hand and go ahead and do a
quick commit on it.

All it involves is adding, just after the "MASTER_SITE_SUBDIR= chess"
line, an explicit:

DISTFILES=  ${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}

This allows the later DISTFILES+= to work as expected (this sure seems
like a bug somewhere in /usr/ports/Mk to me).

Portlint will whine about using DISTFILES= for only a single file
(apparently, it completely overlooks the later DISTFILES+= in deciding
this), and it also wants the EXTRACT_ONLY= line pushed up earlier, but
logically, I think it belongs right where you moved it to.  So, portlint
be damned!  I think we know better.  :-)

Oh, and portlint also seemed to think that the scripts dir was not in
CVS!  Very odd!

Just let me know how you want to handle this, Edwin.  I'd appreciate it
if you'd just go ahead and do a quick fix on this.

Thanks, and once again, sorry for taking so long to getting around to
fixing this.

Conrad

-- 
Conrad J. Sabatier <conrads at cox.net> -- "In Unix veritas"