We need new feature for pkg_create?
Yar Tikhiy
yar at comp.chem.msu.su
Tue Feb 8 14:47:25 PST 2005
On Tue, Feb 08, 2005 at 08:45:28PM +0100, Florent Thoumie wrote:
> Yar Tikhiy wrote:
> >On Mon, Feb 07, 2005 at 05:18:20PM +0100, Florent Thoumie wrote:
> >
> >>>IMHO, what we need is a way to restore the initial prefix setting
> >>>in a packing list. The idea of @pushwd and @popwd looks really
> >>>neat to me. With those commands available, it would be possible
> >>>to append lines using %D or just assuming the current prefix is the
> >>>right one to the final packing list from bsd.port.mk without breaking
> >>>"pkg_add -p /foo".
> >>>
> >>>BTW, here's an example that the problem is rather general. Currently
> >>>using @cwd in port's pkg-plist and PORTDOCS in its Makefile results
> >>>precisely in broken "pkg_add -p /foo" because the build-time prefix
> >>>gets hardcoded in the packing list.
> >>
> >> I don't like the idea of a "working directory" stack because at
> >> most, you'll push one time (or your port is behaving weirdly).
> >
> >
> >This makes sense to me.
>
> I updated the patch this afternoon, this worked for me but
> everyone should be aware that even with this patch, pkg_add -p
> will still not work for a lot of ports since the original prefix
> is often hardcoded during port compilation.
Such ports can be fixed after your modification to pkg tools is
committed. I think it will be worth sending a HEADSUP message to
this list so that port maintainers notice the welcome feature.
> >> FWIW, I just sent a PR with a patch to address this issue [1].
> >> Feel free to add comments in the audit trail.
> >>
> >> [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=77212
> >
> >
> >/usr/src/MAINTAINERS lists eik at freebsd.org as the maintainer of
> >src/usr.sbin/pkg_install. IMHO it should be reasonable to draw
> >his attention to your PR.
>
> According to krion, pkg_install is portmgr territory.
> I have cc'ed eik in my last reply though.
Thanks!
--
Yar
More information about the freebsd-ports
mailing list