A question about dependencies

Oliver Eikemeier eikemeier at fillmore-labs.com
Tue Jun 29 10:17:52 PDT 2004


Hye-Shik Chang wrote:

> On Tue, Jun 29, 2004 at 06:54:44PM +0200, Michael Nottebrock wrote:
>> On Tuesday 29 June 2004 18:41, Hye-Shik Chang wrote:
>>
>>> Without runtime depencency, they will need some treatments to remove
>>> python site packages directory ($PREFIX/lib/python2.3/site-packages).
>>> I see that splitting python ports out from libxml2 and libxslt port
>>> would be better than that.
>>
>> Perhaps. However, it would still be nice to be able to USE_PYTHON in 
>> such a
>> slave port. Is there no way to add some shimmies to bsd.python.mk so a
>> buildtime only dependency becomes feasible?
>>
>
> Okay.  Please review this patch whether it's enough to resolve the
> problem.
>
> Index: Mk/bsd.python.mk
> ===================================================================
> RCS file: /home/pcvs/ports/Mk/bsd.python.mk,v
> retrieving revision 1.50
> diff -u -r1.50 bsd.python.mk
> --- Mk/bsd.python.mk	21 Jun 2004 01:33:52 -0000	1.50
> +++ Mk/bsd.python.mk	29 Jun 2004 17:01:35 -0000
> @@ -275,11 +275,17 @@
>  .endif
>
>  # dependencies
> -PYTHON_NO_DEPENDS?=		NO
> +PYTHON_NO_DEPENDS?=			NO
> +PYTHON_NO_BUILD_DEPENDS?=	NO
> +PYTHON_NO_RUN_DEPENDS?=		NO
>
>  .if ${PYTHON_NO_DEPENDS} == "NO"
> +.if ${PYTHON_NO_BUILD_DEPENDS} == "NO"
>  BUILD_DEPENDS+=	${PYTHON_CMD}:${PYTHON_PORTSDIR}
> +.endif
> +.if ${PYTHON_NO_RUN_DEPENDS} == "NO"
>  RUN_DEPENDS+=	${PYTHON_CMD}:${PYTHON_PORTSDIR}
> +.endif
>  .endif		# ${PYTHON_NO_DEPENDS} == "NO"
>
>  .if defined(USE_ZOPE)

I would like something more uniform, like USE_PYTHON_BUILD, 
USE_PYTHON_RUN checked with defined(). The above seems to be too 
sensitive to bugs like PYTHON_NO_DEPENDS=no, and it is not obvious what 
..._NO_... = "NO" means, contrary to ..._NO_... = "yes".

-Oliver



More information about the freebsd-ports mailing list