Freevo port (TESTING REQUIRED).

Walter Venable weaseal at hotmail.com
Mon Jun 21 12:12:26 PDT 2004




>From: Lewis Thompson <lewiz at fajita.org>
>To: Volker Stolz <vs at freebsd.org>
>CC: Anish Mistry <mistry.7 at osu.edu>, ports at freebsd.org, lars.eggert at gmx.net
>Subject: Re: Freevo port (TESTING REQUIRED).
>Date: Mon, 21 Jun 2004 12:39:37 +0100
>
>On Mon, Jun 21, 2004 at 09:08:48AM +0200, Volker Stolz wrote:
> > In local.freebsd-ports, you wrote:
> > >> I've been working on a port of Freevo (http://freevo.sf.net/), which 
>is
> > >> ``an open-source home theatre PC platform'', for a while now and
> > >> hopefully within a week or two version 1.5.0 will be released.
> >
> > Lewis' submission looks more complete to me. I'd say go ahead and 
>send-pr.
> > Please fix some of the deficiencies reported by portlint before, most 
>notably:
> >
> > 1)
> > WARN: /usr/tmp/freevo/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' 
>and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing. 
>  At least one should be used.
> > FATAL: Makefile: PORTVERSION looks illegal. You should modify 
>"1.5.0rc3".
>
>Hmm, I must admit I completely forgot to run it past portlint (although
>I was aware that 1.5.0rc3 was an invalid PORTVERSION).  I wouldn't have
>spotted the other WARN though, I've only used it minimally before and I
>have to run with --help to figure out the extra options!  Thanks for
>that!
>
> > 3)
> > I don't understand your WITH-handling:
> >
> > .if !defined(WITH_MPLAYER)
> > WITH_MPLAYER=   yes
> > .endif
>
>Well, it seemed to me that if WITH_MPLAYER=0 was specified to make then
>WITH_MPLAYER was defined.  However, if no option was defined then I want
>to install mplayer -- this seemed a nice way to do it at the time.  Have
>I missed the plot here?


Perhaps it should read:

.if !defined(WITHOUT_MPLAYER)
WITH_MPLAYER=   yes
.endif

That seems more logical to me...

_________________________________________________________________
Make the most of your family vacation with tips from the MSN Family Travel 
Guide! http://dollar.msn.com



More information about the freebsd-ports mailing list