Freevo port (TESTING REQUIRED).

[Volker Stolz]

In local.freebsd-ports, you wrote:
>> I've been working on a port of Freevo (http://freevo.sf.net/), which is
>> ``an open-source home theatre PC platform'', for a while now and
>> hopefully within a week or two version 1.5.0 will be released.
>>
>>   In addition to my Freevo port it's important you have a very recent
>> version of mmpython.  If you already have this installed, please upgrade
>> -- it includes some critical disc-specific updates, without which the
>> DVD stuff will really not work right (you'll get 4(c)!).  If you CVSuped
>> in the last couple of days you should be fine.

Please check if this could be encoded in the dependencies somehow...it might
be possible to (ab)use CONFLICTS for this, but that might be over the top.

> I hope you checked the freevo port skeleton submission in the PR database.
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/59047

Lewis' submission looks more complete to me. I'd say go ahead and send-pr.
Please fix some of the deficiencies reported by portlint before, most notably:

1)
WARN: /usr/tmp/freevo/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing.  At least one should be used.
FATAL: Makefile: PORTVERSION looks illegal. You should modify "1.5.0rc3".

Both are errors in you port.

2)
Regarding the required user-ids, please read:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-uid.html

3)
I don't understand your WITH-handling:

.if !defined(WITH_MPLAYER)
WITH_MPLAYER=   yes
.endif
 
.if !defined(WITH_XINE)
WITH_XINE=      yes
.endif

Please also consider using OPTIONS.
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
Neu! Ändern Sie den Anfangstag Ihrer Woche