ftp/ncftp3 problems

[Ilker OZUPAK]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hello,

trying to install ncftp3 and got some problems when trying.
fetching fails with size mismatch error.
when fetched manually make fails with checksum error.
end at last make -DNO_CHECKSUM fails to apply patches.
below is some output from the build proceses..


ps: maintainer CC'ed

**************************************************
pascal# make
===>  Vulnerability check disabled, database not found

Use INSTALL_AS_NCFTP3=yes to install ncftp v3 as /usr/local/bin/ncftp3

>> ncftp-3.1.8-src.tar.bz2 doesn't seem to exist in /home/data/distfiles/.
>> Attempting to fetch from ftp://ftp.ncftp.com/ncftp/.
fetch: ftp://ftp.ncftp.com/ncftp/ncftp-3.1.8-src.tar.bz2: size mismatch: 
expected 401561, actual 401522
>> Attempting to fetch from 
ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/.
fetch: 
ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/ncftp-3.1.8-src.tar.bz2: 
File unavailable (e.g., file not found, no access)
>> Couldn't fetch it - please try to retrieve this
>> port manually into /home/data/distfiles/ and try again.
*** Error code 1

Stop in /usr/ports/ftp/ncftp3.
pascal# cat ../../.ctm_status
ports-cur 5360
>>>>>>>>>>> ctm up .... 
pascal# cat ../../.ctm_status
ports-cur 5362
pascal# make checksum
>>>>>>>>>> same result as above
and manual download fails 

pascal# make -DNO_CHECKSUM
===>  Vulnerability check disabled, database not found

Use INSTALL_AS_NCFTP3=yes to install ncftp v3 as /usr/local/bin/ncftp3

>> ncftp-318-v6-20040720b.diff.gz doesn't seem to exist 
in /home/data/distfiles/.
>> Attempting to fetch from ftp://ftp.kame.net/pub/kame/misc/.
ncftp-318-v6-20040720b.diff.gz                100% of   34 kB   10 kBps
===>  Extracting for ncftp-3.1.8
===>  Patching for ncftp-3.1.8
===>  Applying distribution patches for ncftp-3.1.8
1 out of 29 hunks failed--saving rejects to libncftp/ftp.c.rej
*** Error code 1


- -- libncftp/ftp.c.rej --
***************
*** 1093,1113 ****
                                return (kErrAcceptDataSocket);
                        }
                }
- - 
                if (cip->require20 != 0) {
- -                       remoteDataPort = ntohs(cip->servDataAddr.sin_port);
- -                       remoteCtrlPort = ntohs(cip->servCtlAddr.sin_port);
- -                       if ((int) remoteDataPort != ((int) remoteCtrlPort - 
1)) {
- -                               FTPLogError(cip, kDontPerror, "Data connection 
did not originate on correct port!\n");
- -                               (void) DisposeSocket(newSocket);
- -                               cip->dataSocket = kClosedFileDescriptor;
- -                               cip->errNo = kErrAcceptDataSocket;
- -                               return (kErrAcceptDataSocket);
                        }
                }
                cip->dataSocket = newSocket;
        }
- - 
        return (0);
  }     /* AcceptDataConnection */
  
- --- 1206,1262 ----
                                return (kErrAcceptDataSocket);
                        }
                }
                if (cip->require20 != 0) {
+ #ifdef ENABLE_IPV6
+                       if (cip->servDataAddr.ss_family == AF_INET6) {
+                               struct sockaddr_in6 *servDataAddr =
+                                       (struct sockaddr_in6 *) 
&cip->servDataAddr;
+                               struct sockaddr_in6 *servCtlAddr =
+                                       (struct sockaddr_in6 *) 
&cip->servCtlAddr;
+ 
+                               remoteDataPort = 
ntohs(servDataAddr->sin6_port);
+                               remoteCtrlPort = 
ntohs(servCtlAddr->sin6_port);
+                               if ((int) remoteDataPort != ((int) 
remoteCtrlPort - 1)) {
+                                       FTPLogError(cip, kDontPerror, "Data 
connection did not originate on correct port!\n");
+                                       (void) DisposeSocket(newSocket);
+                                       cip->dataSocket = 
kClosedFileDescriptor;
+                                       cip->errNo = kErrAcceptDataSocket;
+                                       return (kErrAcceptDataSocket);
+                               } else if (memcmp(&servDataAddr->sin6_addr, 
&servCtlAddr->sin6_addr, sizeof(servDataAddr->sin6_addr)) != 0) {
+                                       FTPLogError(cip, kDontPerror, "Data 
connection did not originate from remote server!\n");
+                                       (void) DisposeSocket(newSocket);
+                                       cip->dataSocket = 
kClosedFileDescriptor;
+                                       cip->errNo = kErrAcceptDataSocket;
+                                       return (kErrAcceptDataSocket);
+                               }
+                       } else {
+ #endif
+                               struct sockaddr_in *servDataAddr =
+                                       (struct sockaddr_in *) 
&cip->servDataAddr;
+                               struct sockaddr_in *servCtlAddr =
+                                       (struct sockaddr_in *) 
&cip->servCtlAddr;
+ 
+                               remoteDataPort = 
ntohs(servDataAddr->sin_port);
+                               remoteCtrlPort = ntohs(servCtlAddr->sin_port);
+                               if ((int) remoteDataPort != ((int) 
remoteCtrlPort - 1)) {
+                                       FTPLogError(cip, kDontPerror, "Data 
connection did not originate on correct port!\n");
+                                       (void) DisposeSocket(newSocket);
+                                       cip->dataSocket = 
kClosedFileDescriptor;
+                                       cip->errNo = kErrAcceptDataSocket;
+                                       return (kErrAcceptDataSocket);
+                               } else if 
(memcmp(&servDataAddr->sin_addr.s_addr, &servCtlAddr->sin_addr.s_addr, 
sizeof(servDataAddr->sin_addr.s_addr)) != 0) {
+                                       FTPLogError(cip, kDontPerror, "Data 
connection did not originate from remote server!\n");
+                                       (void) DisposeSocket(newSocket);
+                                       cip->dataSocket = 
kClosedFileDescriptor;
+                                       cip->errNo = kErrAcceptDataSocket;
+                                       return (kErrAcceptDataSocket);
+                               }
+ #ifdef ENABLE_IPV6
                        }
+ #endif                
                }
                cip->dataSocket = newSocket;
        }
        return (0);
  }     /* AcceptDataConnection */
  

- --
IO
- --
gpg public key @ http://cmpe.emu.edu.tr/ilker/ilker.asc
pub  1024D/A4F41BD0 2003-07-16 Ilker Ozupak <ilker.ozupak at emu.edu.tr>
Primary key fingerprint: E509 17B6 C8E2 ADB7 32A7  4746 BF14 814A A4F4 1BD0
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFBB2qNvxSBSqT0G9ARAkNtAJ0SIM6NiX7Hcnlwugp4ngecYlIC4ACfX7rt
lbazEkJuWMjS3eE/nPawIR8=
=CuLK
-----END PGP SIGNATURE-----