FreeBSD Port: jfreechart-0.9.13

[Sepherosa Ziehau]

On Fri, 23 Jan 2004 12:39:24 +0000, Matthew Seaman 
<m.seaman at infracaninophile.co.uk> wrote:

> On Fri, Jan 23, 2004 at 07:28:08PM +0800, Sepherosa Ziehau wrote:
>> without a java document, a java library is useless.  I have upgraded
>> jfreechart to 0.9.16 and add javadoc support.
>> Hope somebody can review it and commit it for me.
>
> Nice work.  However, I can see a couple of problems with your patch.
>
> You're building javadocs with one of a number of possible JDKs, and
> that has the unfortunate consequence that the plist for the generated
> Javadocs is different for different JDK versions.  You're also using
> ant(1) to do the build, which overrides the settings obtained by
> USE_JAVA=x.y and instead uses whatever the default JDK on the system
> is.  (Normally those JDKs will be the same, but not always.)
>
> You can easily solve the pkg-plist problem by use of the PORTDOCS make
> variable -- which also has the handy side effect of keeping the
> pkg-plist file for the port nice and short.  See the
> databases/mysql-connector-java port I maintain for an example.
>
> You can (if you think it's necessary) solve the ant(1) version problem
> by:
>
>     ANT=    ${SETENV} JAVA_HOME=${JAVA_HOME} ant
>
> You also need a BUILD_DEPENDS on the devel/apache-ant port.
>
> 	Cheers,
>
> 	Matthew
>

Thank you for your advice, and the nice mysql-connector.
I regenerated the patch according to your advice.
Please review it.

Best Regards
Sepherosa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.jfreechart
Type: application/octet-stream
Size: 1309 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20040124/32aad7e2/patch.obj