PORTVERSION and portlint

[Joe Marcus Clarke]

On Wed, 2003-11-26 at 17:26, Sergey Matveychuk wrote:
> What's wrong with '+' sign in PORTVERSION?
> www/apache13+modssl, russian/apache* and dns/bind9-dlz ports use it for 
> separating port version and module version. I think it's a good practice.

The idea is to test for PKGVERSIONs that pkg_version cannot handle. 
However, the '+' notation seems to be correctly handled by pkg_version
on -CURRENT and -STABLE (at least with apache-modssl).

> 
> But portlint marks it as FATAL. May be make a sense this simple patch to 
> apply?

Yeah, this makes sense.

Joe

> 
> ---
> Sem.
> 
> ______________________________________________________________________
> --- portlint.orig	Thu Nov 27 01:22:30 2003
> +++ portlint	Thu Nov 27 01:23:04 2003
> @@ -1535,7 +1535,7 @@
>  		&perror("FATAL: $file: PORTVERSION must be specified");
>  	}
>  	if ($portversion =~ /^pl[0-9]*$/
> -	|| $portversion =~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9]*)*$/) {
> +	|| $portversion =~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9+]*)*$/) {
>  		print "OK: PORTVERSION \"$portversion\" looks fine.\n" if ($verbose);
>  	} elsif ($portversion =~ /^[^\-]*\$[{\(].+[\)}][^\-]*$/) {
>  		&perror("WARN: $file: using variable, \"$portversion\", as version ".
-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	marcus at FreeBSD.org
gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20031126/42c503d3/attachment.bin