Restoration of usr.bin/make/cond.c cures INDEX build on -stable (Was: Re: make index problems)

[Igor B. Bykhalo]

From: "Kent Stewart" <kstewart at owt.com>
To: "Kris Kennaway" <kris at obsecurity.org>; "Stephen Hilton" <nospam at hiltonbsd.com>
Cc: <freebsd-ports at freebsd.org>
Sent: Monday, July 28, 2003 6:48 AM
Subject: Re: make index problems


> On Sunday 27 July 2003 04:51 pm, Kris Kennaway wrote:
> > On Sun, Jul 27, 2003 at 11:30:43AM -0500, Stephen Hilton wrote:
> > > Went to /usr/ports/print and did:
> > > # rm -rf pips*
> > >
> > > To remove all the print/pips* related ports.
> > >
> > > Now "make index" runs clean on my 4.8-STABLE system cvsup'd
> > > last night.
[...]
>
> All of this seemed to pop up when the do_string_compare in
> ../usr.bin/make/cond.c was updated.

Which happened 6 days ago, according to

http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.bin/make/cond.c?only_with_tag=RELENG_4

And all these days make index was broken on my machine...
I kept scilence, because usually i receive Kris's announcements
of INDEX build failures.

Now experiment:

1.
>>>> Attempt to build index...

Script started on Mon Jul 28 11:02:58 2003
goshik# cd /usr/ports ; make index ; cd /usr/local/etc; exit

Generating INDEX - please wait.."/usr/ports/print/pips2200/../pips800/Makefile", line 60: Malformed conditional (${PRTYPE} == 780cs)
"/usr/ports/print/pips2200/../pips800/Makefile", line 63: Malformed conditional (${PRTYPE} == 820ug)
"/usr/ports/print/pips2200/../pips800/Makefile", line 1: Malformed conditional (${PRTYPE} == 750_2000)
"/usr/ports/print/pips2200/../pips800/Makefile", line 1: Need an operator
"/usr/ports/print/pips2200/../pips800/Makefile", line 5: Malformed conditional (${PRTYPE} == 780cs)
"/usr/ports/print/pips2200/../pips800/Makefile", line 7: Malformed conditional (${PRTYPE} == 820ug)
"/usr/ports/print/pips2200/../pips800/Makefile", line 305: if-less endif
"/usr/ports/print/pips2200/../pips800/Makefile", line 305: Need an operator
make: fatal errors encountered -- cannot continue
make_index: icemc-0.2.4: no entry for /usr/ports/x11-toolkits/qt31
[...]
make_index: bugzilla-2.16.3_1: no entry for /usr/ports/www/p5-Template-Toolkit
Warning: Duplicate INDEX entry: *** Error code 1
Warning: Duplicate INDEX entry:
 Done.
exit

Script done on Mon Jul 28 11:13:07 2003

>>>> Attempt failed

2.
>>>> Revert usr.bin/make/cond.c 1 week back

Script started on Mon Jul 28 11:28:30 2003
goshik# pwd

/usr/src
goshik# cd usr.bin/make

goshik# cvs -n update -rRELENG_4 -D "2003-07-22 01:00" -f cond.c

U cond.c
goshik# make all install clean

cc -O -pipe  -I/usr/src/usr.bin/make    -c /usr/src/usr.bin/make/cond.c
cc -O -pipe  -I/usr/src/usr.bin/make     -static -o make arch.o buf.o compat.o cond.o dir.o for.o hash.o job.o main.o make.o parse.o
str.o suff.o targ.o var.o util.o lstAppend.o lstAtEnd.o lstAtFront.o lstClose.o lstConcat.o lstDatum.o lstDeQueue.o lstDestroy.o
lstDupl.o lstEnQueue.o lstFind.o lstFindFrom.o lstFirst.o lstForEach.o lstForEachFrom.o lstInit.o lstInsert.o lstIsAtEnd.o
lstIsEmpty.o lstLast.o lstMember.o lstNext.o lstOpen.o lstRemove.o lstReplace.o lstSucc.o
install -s -o root -g wheel -m 555   make /usr/bin
install -o root -g wheel -m 444 make.1.gz  /usr/share/man/man1
rm -f make arch.o buf.o compat.o cond.o dir.o for.o hash.o job.o main.o make.o parse.o str.o suff.o targ.o var.o util.o lstAppend.o
lstAtEnd.o lstAtFront.o lstClose.o lstConcat.o lstDatum.o lstDeQueue.o lstDestroy.o lstDupl.o lstEnQueue.o lstFind.o lstFindFrom.o
lstFirst.o lstForEach.o lstForEachFrom.o lstInit.o lstInsert.o lstIsAtEnd.o lstIsEmpty.o lstLast.o lstMember.o lstNext.o lstOpen.o
lstRemove.o lstReplace.o lstSucc.o make.1.gz make.1.cat.gz
goshik# cd /usr/ports; make index; cd /usr/local/etc
Generating INDEX - please wait.. Done.
goshik# portversion -vL "="

[Updating the portsdb <format:bdb1_btree> in /usr/ports ... - 9024 port entries found
.........1000.........2000.........3000.........4000.........5000.........6000.........7000.........8000.........9000 ..... done]
ghostscript-gnu-7.07_2      <  needs updating (port has 7.07_3)
goshik# exit

exit

Script done on Mon Jul 28 12:04:21 2003

>>>> Index built fine here...

Clearly there is something wrong with make...

HTH,
Igor


> Kent
>
> -- 
> Kent Stewart
> Richland, WA
>
> http://users.owt.com/kstewart/index.html