prying x11-wm/wmakerconf loose from gnome

[Joe Marcus Clarke]

On Thu, 2003-12-18 at 02:46, Brandon D. Valentine wrote:
> TO  Dominik (wmakerconf maintainer),
>     freebsd-ports (gnome2wmaker maintainer),
>     and freebsd-gnome,
> 
> My apologies for the crosspost, but I'm looking for some advice on
> eliminating this:
> 
>     % pkg_info -r wmakerconf-2.8.1 | wc -l
>           68
> 
> The wmakerconf port does not require gnome, except that it does.  The
> Makefile for wmakerconf contains this:
> 
>     [...]
>     USE_GNOME=      imlib
>     WANT_GNOME=     yes
>     [...]
>     .if defined(HAVE_GNOME)
>     BUILD_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker
>     RUN_DEPENDS+=   gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker
>     PLIST_SUB+=     GNOME:=""
>     .else
>     PLIST_SUB+=     GNOME:="@comment "
>     .endif
>     [...]
> 
> '.if defined(HAVE_GNOME)' will always evaluate to true as the port has
> just declared its dependency on imlib above.  Thus, wmakerconf _always_
> adds gnome2wmaker to its dependency list.  This is a non-trivial
> addition as gnome2wmaker's Makefile uses the old 'USE_GNOME=yes' syntax
> which sucks in all of gnomeprefix, gnomehack and gtkhtml.  gtkhtml
> pretty much takes care of sucking the rest of gnome in by declaring
> 'USE_GNOME=gnomehack gnomeprefix gnomehier glibwww libghttp libcapplet
> gal'.
> 
> In this way we end up with 68 dependencies for a simple little program
> like wmakerconf.
> 
> I would like to submit some PRs w/ patches to clean all of this up (or
> have a committer reading this just go and fix it without hassling around
> with gnats).  Both x11-wm/wmakerconf and x11-wm/gnome2wmaker need to be
> fixed.
> 
> gnome2wmaker needs to comply with the new bsd.gnome.mk policy regarding
> USE_GNOME, i.e. no more 'USE_GNOME=yes'.  It should do this by setting
> USE_GNOME to whichever gnome component provides "menus".  gnome2wmaker's
> purpose is to insert the gnome menu into the windowmaker menu, so it
> should require the part of gnome that provides menus.  It is not
> immediately clear to me which component that might be.  Perhaps one of
> the freebsd-gnome boys can shed some light on that.
> 
> wmakerconf needs to be updated so that instead of testing to see if
> HAVE_GNOME is defined, it checks HAVE_GNOME for the same "menu"
> component.  If that component is installed, then it should add
> gnome2wmaker to its dependencies.
> 
> Which of the gnome components contains the "menus" and should be tested
> against?  Should I submit PRs+patches or is there some ports or gnome
> committer who would prefer to clean these up?  They both should be
> simple to fix.

I agree this is a bug in wmakerconf, but someone will need to determine
which GNOME component to check for, then modify the HAVE_GNOME test to
be:

.if ${HAVE_GNOME:Mcomponent}!=""
...

At that point, the problem should go away.  Given that no one has truly
migrated this port to the new GNOME infrastructure, that "component"
could be gtkhtml (however, I'm sure gnomelibs would suffice).

Joe

> 
> Thanks,
> 
> Brandon D. Valentine
-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20031218/c253fabc/attachment.bin