[Bug 253086] New Port: sysutils/nq: create queues of jobs which will run one at at time in the background of the shell

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Jan 30 10:09:00 UTC 2021


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253086

daniel.engberg.lists at pyret.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.engberg.lists at pyret.
                   |                            |net

--- Comment #5 from daniel.engberg.lists at pyret.net ---
Nice progress!

PORTVERSION --> DISTVERSION
"Example 5.12. Use of USE_GITHUB with DISTVERSIONPREFIX"
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-description

I would strongly advice you not to fork upstream especially when upstream is
still active and on top of that increment version numbers as this makes breaks
our tools for automatic checks of updates. This will also break as pkg-descr
refers to upstream repo

Instead apply your changes as patches which can be easily accomplished and
don't increment upstream version.

Revert back to upstream, add your patches to the ports Makefile (unless it
requires ~4+ files)
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#porting-patchfiles

Example:
https://svnweb.freebsd.org/ports/head/multimedia/dvdread/Makefile?revision=561359&view=markup

Please run portlint and if possible poudriere
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#porting-portlint
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#testing-poudriere

I apologize for sounding a bit pedantic but it really easies maintenance burden
if we all try to follow the handbook as close as possible and it makes it a lot
easier for the next person to tell what's going on/what you're trying to
accomplish.

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list