[Bug 253086] New Port: sysutils/nq: create queues of jobs which will run one at at time in the background of the shell

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253086

--- Comment #1 from daniel.engberg.lists at pyret.net ---
Hi,

Thanks for your submission, a few issues however that needs attention

Please have a look at "Example 5.12. Use of USE_GITHUB with DISTVERSIONPREFIX "
in Porter's Handbook -
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-description

LICENSE_FILE= entry is missing
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/licenses.html

Seems to compile fine without gmake? (Remove USES line)

Projects Makefile overrides CFLAGS and potentially other variables such as
PREFIX set by framework
https://github.com/leahneukirchen/nq/blob/master/Makefile#L3
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/dads-cflags.html
The general solution for the other variables is to use ?= instead of =

Fix --> 4.4. Patching and preferably if possible submit changes upstream
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/slow-patch.html

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.