[Bug 252629] Need infrastructure to set ELF feature note flags via elfctl

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Jan 26 14:47:56 UTC 2021


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252629

--- Comment #15 from commit-hook at FreeBSD.org ---
A commit in branch stable/12 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=d7e23b5cdd8465bd50f88b1e38cb695a361a26f5

commit d7e23b5cdd8465bd50f88b1e38cb695a361a26f5
Author:     Ed Maste <emaste at FreeBSD.org>
AuthorDate: 2021-01-22 17:22:35 +0000
Commit:     Ed Maste <emaste at FreeBSD.org>
CommitDate: 2021-01-26 14:46:00 +0000

    elfctl: allow features to be specified by value

    This will allow elfctl on older releases to set bits that are not yet
    known there, so that the binary will have the correct settings applied
    if run on a later FreeBSD version.

    PR:             252629 (related)
    Suggested by:   kib
    Reviewed by:    gbe (manpage, earlier), kib
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D28284

    (cherry picked from commit 86f33b5fcf6087bf4439881011b920ff99e6e300)

    elfctl: fix typo from last-minute refactoring

    Reported by:    jkim

    (cherry picked from commit f302fd1aa6730facd53a3f761e0a57302731b03e)

    elfctl: Fix type errors.

    Target value for val has uint32_t type, not uint, adjust used constant.
    Change val type to unsigned so that left and right sides of comparision
    operator do not expose different signed types of same range [*].

    Switch to unsigned long long and strtoll(3) so that 0x80000000 is
    accepted by conversion function [**].

    Reported by:    kargl [*]
    Noted by:       emaste [**]
    Reviewed by:    emaste
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D28301

    (cherry picked from commit 9940ac808de7b7d4ed0408c3e739f667dca06d3b)

 usr.bin/elfctl/elfctl.1 | 15 +++++++++++++--
 usr.bin/elfctl/elfctl.c | 26 +++++++++++++++++++++++---
 2 files changed, 36 insertions(+), 5 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list