[Bug 252558] misc/findutils update to 4.8.0

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Jan 11 12:26:22 UTC 2021


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252558

Rainer Hurling <rhurlin at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rhurlin at FreeBSD.org

--- Comment #3 from Rainer Hurling <rhurlin at FreeBSD.org> ---
Created attachment 221455
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=221455&action=edit
Modified with ordered vars, corrected patch file, and without sig file

Hi Klaus,

Thanks for patch.

After investigating a bit, I came across a few points with your patch that I
would like to clarify:

- 'portlint -AC' indicated that something is wrong with
files/patch-gl_lib_fdopendir.c. It turned out that this file was not created by
'make makepatch' and was also wrongly named.

- 'portclippy Makefile' (from ports-mgmt/portfmt) gives hints about the order
of variables in the Makefile. I have reordered accordingly.

- It is not clear to me what the signature file is downloaded for. Surely it is
not used afterwards? For now, I commented it out. If you agree, it will be
removed from the Makefile and the distinfo.

- LOCALSTATDIR should point to the location where glocate finds the
locate.database? This does not seem to work. glocate does not use the existing
locate.database under /var/db until this is explicitly specified in the call:

glocate --database=/var/db/locate.database xyz...

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list