[Bug 251153] net/rdesktop 1.9.0 core dumps

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251153

--- Comment #9 from rozhuk.im at gmail.com ---
(In reply to Ivan from comment #8)

I found in mail list that gnutls_x509_crt_get_fingerprint() fails with -72 for
rdesktop.


Typical usage for gnutls_x509_crt_get_fingerprint():

int error;
uint8_t digest[1024];
size_t digest_size;

digest_size = sizeof(digest);
error = gnutls_x509_crt_get_fingerprint(crt_list[0],
    GNUTLS_DIG_MD5, digest, &digest_size);

on error digest_size not changed.


I am does not see rdesktop code, but suspect that it does not proper handle
error for gnutls_x509_crt_get_fingerprint().
Probably more proper fix would be add error handler and set digest_size to
zero:

error = gnutls_x509_crt_get_fingerprint(crt_list[0],
    GNUTLS_DIG_MD5, digest, &digest_size);
if (0 != error) {
        digest_size = 0;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.