[Bug 252497] audio/zita-resampler: Update to 1.8.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252497

--- Comment #7 from Fernando Apesteguía <fernape at FreeBSD.org> ---
(In reply to daniel.engberg.lists from comment #6)

Apparently it does.

/tmp/252497/audio/zita-resampler$ portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to
make SVN happy.
WARN: /tmp/252497/audio/zita-resampler/files/patch-CMakeLists.txt: patch was
not generated using ``make makepatch''.  It is recommended to use ``make
makepatch'' when you need to [re-]generate a patch to ensure proper patch
format.

/tmp/252497/audio/zita-resampler$ make patch

===>  License GPLv3+ accepted by the user
===>   zita-resampler-1.8.0 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by zita-resampler-1.8.0 for building
===>  Extracting for zita-resampler-1.8.0
=> SHA256 Checksum OK for zita-resampler-1.8.0.tar.bz2.
===>  Patching for zita-resampler-1.8.0
===>  Applying FreeBSD patches for zita-resampler-1.8.0

/tmp/252497/audio/zita-resampler$ make makepatch
Generated patch-CMakeLists.txt
The previous patches have been placed here:
/tmp/252497/audio/zita-resampler/work/.makepatch-tmp/archived-patches

/tmp/252497/audio/zita-resampler$ portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to
make SVN happy.

Now... I'm not completely sure about replacing the upstream Makefile with
CMake. For one, it (obviously) pulls CMake in the dependencies list that is not
super light to build. Also, what if we commit this and upstream does not accept
the CMakeList.txt? Are we going to port all the things in the upstream Makefile
to the CMakeList.txt when something changes?

Don't get me wrong, I think CMake is in general far superior than old GNU
tools, but wouldn't it be better to send the patch upstream and wait and see if
they adopt it?

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.