[Bug 244204] ports-mgmt/dialog4ports - Segmentation fault after upgrade to 13.x-currrent

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244204

--- Comment #13 from Joshua Kinard <kumba at gentoo.org> ---
> Hi Joshua,
> Can you try attached patch?
> Need put it into /usr/ports/ports-mgmt/dialog4ports/files and rebuild d4p like 
> make -C /usr/ports/ports-mgmt/dialog4ports clean build deinstall install
> Actually, I still cant reproduce problem ;(
> Thanks in advance.
> 
> --- mixedlist.c_old	2021-01-03 16:01:52.851092000 +0300
> +++ mixedlist.c	2021-01-03 16:06:04.266150000 +0300
> @@ -652,12 +652,12 @@
>  						break;
>  					case DLGK_ITEM_PREV:
>  						i = choice - 1;
> +						if (choice == 0 && scrollamt == 0)
> +							continue;
>  						if (items[scrollamt + i].type == ITEM_SEPARATOR && (scrollamt + i) == 0)
>  							i++;
>  						else if (items[scrollamt + i].type == ITEM_SEPARATOR)
>  							i--;
> -						if (choice == 0 && scrollamt == 0)
> -							continue;
>  						break;
>  					case DLGK_ITEM_NEXT:
>  						i = choice + 1;> 
> -- 
> With Best Regards,
> Ilya A. Arkhipov

Just rebuilt dialog4ports with this patch, and the issue is not reproducible
anymore.

Not sure what's different about my environment, but I can tell you some
parameters and maybe one of them is a factor:

  - PuTTY v0.74 from a Windows desktop to the FreeBSD system
  - Shell is /usr/local/bin/bash
  - TERM is xterm-256color
  - LANG is en_US.ISO8859-15
  - MM_CHARSET is ISO-8859-15
  - /usr/ports is mounted over NFSv4.1 onto the target system (the NFS server
also runs FreeBSD and reproduces the same issue locally)

-- 
You are receiving this mail because:
You are the assignee for the bug.