[Bug 253303] sysutils/memtest86+: remove dependency on gcc48

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253303

            Bug ID: 253303
           Summary: sysutils/memtest86+: remove dependency on gcc48
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: kevans at freebsd.org

Created attachment 222218
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=222218&action=edit
git(1) diff against the ports tree

This is one of three ports still explicitly dependent on lang/gcc48. The
problems that were preventing the upgrade were as follows:

- The __OUT*/__IN* macros in io.h were declaring the produced functions as
extern, yielding multiple "definitions." They're inline asm, so just give them
static linkage.

- reboot was declared inline with non-static linkage, thus leaving it in a
weird state where it wasn't visible within the same CU or another CU. Drop the
inline for now; if it really needs to be inlined, it can be moved into a header
and declared `static inline`.

I made these changes, then discovered there's a 5.31b that's still in testing.
I checked the archive for that and was delighted to discover these changes had
already actually been made there, too, so let's consider this a backport.

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Maintainer informed via mail

-- 
You are receiving this mail because:
You are the assignee for the bug.