[Bug 255496] [NEW-PORT] audio/ZMusic

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255496

Kalten <kalten at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224557|0                           |1
        is obsolete|                            |

--- Comment #16 from Kalten <kalten at gmx.at> ---
Created attachment 224559
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=224559&action=edit
Shell-Archive for new port audio/ZMusic (04)

(In reply to Chris Hutchinson from comment #15)
> OK this should probably work.
> But I recommend not abusing LICENSE_FILES
> like this. As this is not how the LICENSE
> framework is intended to be used.
Oh! I am sorry! I did not look up, whether this variable is used—admittedly
stupid of me :-(

> Why not define LFILES and simply use that
> instead. The same end goal is reached, and
> it will never have unintended consequences
> in the future. Something like:
> 
> USE_LDCONFIG=	yes
> 
> LFILES=	bsd.txt dumb.txt gplv3.txt legal.txt lgplv21.txt \
> lgplv3.txt zmusic.txt
> 
> and
> 
> ${INSTALL_DATA} ${LFILES:S|^|${WRKSRC}/licenses/|} ${STAGEDIR}${DOCSDIR}
> 
> instead.
I have changed it (see new audio_ZMusic_04.shar)

> Otherwise everything should be just fine. :-)
Very good!

Thank you,
 Kalten

-- 
You are receiving this mail because:
You are the assignee for the bug.