[Bug 255442] New port: "sysutils/discus" - similar to df but nicer output

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255442

Rainer Hurling <rhurlin at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freebsd at ny-central.org,
                   |                            |rhurlin at FreeBSD.org
 Attachment #224496|                            |maintainer-approval?(freebs
              Flags|                            |d at ny-central.org)

--- Comment #1 from Rainer Hurling <rhurlin at FreeBSD.org> ---
Created attachment 224496
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=224496&action=edit
patch with corrections and more

Hi Chris,

Thanks for the patch.

> Did my best to build a port for it, since it was on the wishlist...
Looks nice for a first shot of a new port ;)

> portlint looked fine, followed the porter's handbook and tested
> on amd64 in different constellations / different python versions.
I stumbled over some issues, while trying to build and test your port.

- The first line in Makefile (# $FreeBSD$) is not needed any
  more, after the ports tree is converted from svn to git

- If you like it, a first line like this
  # Created by: Chris Moerz <freebsd at ny-central.org>
  can be included. Be warned, this is not very common any more

- For me, the port didn't fetch the source. This was because
  of an uncomplete PORTVERSION, which you tried you overcome
  by GH_TAGNAME ...
  Removing the distinfo file and recreating after my changes did it

- The minimal Python 3 version nowadays should be 3.6+

- USE_PYTHON=allflavors is for 'special cases' (Mk/Uses/python.mk):
  "Only to be used for py-* ports that are part of the Python
  distribution, but kept as separate ports"

- LICENSE_FILE not needed for this 'standard license'

- USES=shebangfix and SHEBANGFIX_FILES instead of post-patch

- PORTDOCS not needed here, but something for the case, option
  DOCS is disabled: 'do-install-DOCS-on:' target should do the trick

- New distinfo

- pkg-plist: sbin/discus has the rights already. Adding %%PORTDOCS%%
  makes the DOCS files depending on the option

Probably I did not found every issue so far, but let's see ;)


If you agree with my suggestion, could you please test it and give some
feedback?

-- 
You are receiving this mail because:
You are the assignee for the bug.