[Bug 254685] devel/libegit2: libgit module install directory does not match Emacs version, when using emacs-devel (Patch Attached)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254685

            Bug ID: 254685
           Summary: devel/libegit2: libgit module install directory does
                    not match Emacs version, when using emacs-devel (Patch
                    Attached)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: lab+bsd at thinkum.space
                CC: yasu at utahime.org
             Flags: maintainer-feedback?(yasu at utahime.org)
                CC: yasu at utahime.org

Created attachment 223737
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=223737&action=edit
Patch devel/libegit2 for libgit install dir

When magit-devel is built with the LIBEGIT2 port option for emacs-devel, it may
not be able to find libegit2. 

As a workaround, a site using emacs-devel may be able provide a site-lisp expr,
such that would set libgit--module-file for the correct directory for the Emacs
version under emacs-devel. Presently, this would be
"/usr/local/share/emacs/28.0.50/site-lisp" under normal LOCALBASE

A patch is attached for the patch-libgit.el under devel/libegit2 such that
would serve to ensure that the matching, versioned site lisp directory will be
used for libgit--module-file. 

The previous patch file used a hard-coded Emacs version. However, from the
contents of the port Makefile, it may seem that this build-time pathname
replacement was already partially supported.

This patch has been tested for build and for usage with Magit, under
devel/magit-devel at devel_full with the LIBEGIT2 port option enabled


To mention one known concern with the patch as provided here, the patch file
updated with the provided ports-tree patch would use a different timestamp
format than the original patch file under devel/libegit2. Personally, I'm not
certain how to get diff(1) to use the same timestamp format as the original -
does it need a specific locales def?

The patched code has been tested though.


Health.

- Sean Champ

-- 
You are receiving this mail because:
You are the assignee for the bug.