[Bug 246342] [NEW PORT] audio/strawberry: Music Player

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246342

daniel.engberg.lists at pyret.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.engberg.lists at pyret.
                   |                            |net

--- Comment #1 from daniel.engberg.lists at pyret.net ---
Hi,

CATEGORIES should be audio not multimedia

According to 
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html
you shouldn't use both MASTER_SITES and USE_GITHUB.
Is there anything wrong using the provided archive by upstream?

https://www.strawberrymusicplayer.org/ --> Download - Source -->
https://files.jkvinge.net/packages/strawberry/strawberry-0.6.10.tar.xz

I might be interpreting the handbook incorrectly but I think you shouldn't
include xorg and gnome in USES
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-gnome.html
There's no example for xorg but I assume it follows the same concept.

Having a luck look at the Makefile you seem to be missing a few libs and have a
few redundant?

Missing: Boost, taglib (should use ports not bundled), pkgconfig etc

https://github.com/strawberrymusicplayer/strawberry/blob/0.6.10/CMakeLists.txt#L88
https://github.com/strawberrymusicplayer/strawberry/blob/0.6.10/CMakeLists.txt#L89
https://github.com/strawberrymusicplayer/strawberry/blob/0.6.10/CMakeLists.txt#L203

VLC isn't needed and more or less unsupported
https://github.com/strawberrymusicplayer/strawberry/blob/0.6.10/CMakeLists.txt#L123
https://github.com/strawberrymusicplayer/strawberry/blob/0.6.10/CMakeLists.txt#L442

You don't need two audio backends, in that case Pulseaudio seems to be the
better choice as alsa-lib is very old in ports (it seems like you can choose?).

There are more so you need to check that part again, preferably all optional
libraries should be optional via menu options.
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

Fails using Poudriere due to missing libs

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.