[Bug 244239] ports-mgmt/portlint: strange output for security/p5-IO-Socket-SSL

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244239

--- Comment #3 from Sergei Vyshenski <svysh.fbsd at gmail.com> ---
Hi,

A note for discussion.

Subroutine of /usr/local/bin/portlint named
sub get_makevar_shallow {}
forms argument list for "make" as follows (see line 3821):

$cmd = join(' -dV -V ', "make $makeenv MASTER_SITE_BACKUP=''", map { "'$_'" }
@_);

which causes exactly reported garbage:

$ cd /usr/ports/security/p5-IO-Socket-SSL
$ make MASTER_SITE_BACKUP='' -dV -V 'RUN_DEPENDS'
p5-Net-SSLeay>=1.59:security/p5-Net-SSLeay 
p5-Mozilla-CA>=20130114:www/p5-Mozilla-CA ${${:UIDN}_${:URUN}_DEPENDS}
${${:UIPV6}_${:URUN}_DEPENDS} ${PERL5_DEPEND}:lang/${PERL_PORT}
$ portling -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to
make SVN happy.
WARN: Makefile: no port directory /usr/ports/UIPV6}_${ found, even though it is
listed in BUILD_DEPENDS.
0 fatal errors and 2 warnings found.

The "-dV" flag for make suppresses variable expansion, and seems irrelevant for
the ports with conditional dependency list. 
If this flag is omitted from line 3821 of /usr/local/bin/portlint, that is:

$cmd = join(' -V ', "make $makeenv MASTER_SITE_BACKUP=''", map { "'$_'" } @_);

the garbage is gone:

$ cd /usr/ports/security/p5-IO-Socket-SSL
$ make MASTER_SITE_BACKUP='' -V 'RUN_DEPENDS'
p5-Net-SSLeay>=1.59:security/p5-Net-SSLeay 
p5-Mozilla-CA>=20130114:www/p5-Mozilla-CA p5-URI>=1.50:net/p5-URI
p5-IO-Socket-INET6>0:net/p5-IO-Socket-INET6 perl5>=5.30.r1<5.31:lang/perl5.30
$ portling -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to
make SVN happy.
0 fatal errors and 1 warning found.

Sorry for slow thinking, and not sure though if the proposed change fits for
the rest of the world.

Regards, Sergei

-- 
You are receiving this mail because:
You are the assignee for the bug.