[Bug 243857] New Port: /sysutils/xdisk - a partition editor

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243857

Adam Weinberger <adamw at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adamw at FreeBSD.org

--- Comment #7 from Adam Weinberger <adamw at FreeBSD.org> ---
This program looks cool! Some issues:

1) Why is this pulling a single file out of source control? That doesn't seem
ideal. There's no guarantee that that file won't change or disappear in any
future commit. Also it seems strange that people checking out from git should
have to download tarballs. Ideally it should be pulling a tag, or a file from
releases.

2) All the args to ${INSTALL_PROGRAM} are unnecessary (and the mode is
wrong---binaries should be installed 555, as they are by default, and not 755).
root:wheel and mode 555 happens automatically. And while we're here: no slash
needed after ${STAGEDIR} (${LOCALBASE} starts with a /):
${STAGEDIR}${LOCALBSE}/...

3) The upstream Makefile hardcodes /usr/local, which need to be substituted.
See
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-patch.html#slow-patch-automatic-replacements

4) Ideally, the Makefile should be getting the glib/gtk/cairo/pango/etc. from
pkg-config, not by hardcoding. That's up to developer preference but we'd
certainly urge it.

-- 
You are receiving this mail because:
You are the assignee for the bug.