[Bug 244645] biology/jellyfish

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244645

            Bug ID: 244645
           Summary: biology/jellyfish
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: jwb at freebsd.org
          Reporter: dim at FreeBSD.org
            Blocks: 244251
             Flags: maintainer-feedback?(jwb at freebsd.org)
          Assignee: jwb at freebsd.org

Created attachment 212207
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=212207&action=edit
Fix biology/jellyfish build with clang 10.0.0

As reported in bug 244251, with clang 10.0.0 the biology/jellyfish port runs
into -Werror warnings:

lib/jsoncpp.cpp:2303:74: error: implicit conversion from 'const Json::Int64'
(aka 'const long long') to 'double' changes value from 9223372036854775807 to
9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
      JSON_ASSERT_MESSAGE( value_.real_ >= minInt64  &&  value_.real_ <=
maxInt64, "Real out of Int64 range" );
                                                                      ~~
^~~~~~~~
lib/jsoncpp.cpp:1566:58: note: expanded from macro 'JSON_ASSERT_MESSAGE'
#define JSON_ASSERT_MESSAGE( condition, message ) if (!( condition ))
JSON_FAIL_MESSAGE( message )
                                                         ^~~~~~~~~
lib/jsoncpp.cpp:2331:67: error: implicit conversion from 'const Json::UInt64'
(aka 'const unsigned long long') to 'double' changes value from
18446744073709551615 to 18446744073709551616
[-Werror,-Wimplicit-int-float-conversion]
      JSON_ASSERT_MESSAGE( value_.real_ >= 0  &&  value_.real_ <= maxUInt64, 
"Real out of UInt64 range" );
                                                               ~~ ^~~~~~~~~
lib/jsoncpp.cpp:1566:58: note: expanded from macro 'JSON_ASSERT_MESSAGE'
#define JSON_ASSERT_MESSAGE( condition, message ) if (!( condition ))
JSON_FAIL_MESSAGE( message )
                                                         ^~~~~~~~~

This can be fixed by adding explicit casts.


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244251
[Bug 244251] [exp-run] Against projects/clang1000-import branch
-- 
You are receiving this mail because:
You are the assignee for the bug.