[Bug 238773] multimedia/x265: Only highest bit-depth profile is built when multiple (bit-depth OPTIONS) are selected

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238773

--- Comment #10 from Jamie Landeg-Jones <jamie at catflap.org> ---
(In reply to daniel.engberg.lists from comment #8)

Apologies for not having the time to get back to this as I promised, but
brilliant job sorting it out!

I haven't tried running it yet, but it looks good.

As for your original question about whether to install 8, 10, 12 by default.
Originally, I was going to make each one optional - installing the 3 basically
triples compile time / library disk usage.

However, when the coffee finally kicked in, I realised that this will only be
installed for encoding x265. Any machine that has problems with a slightly
bigger library, and the extended compile time won't be suitable for x265
encoding!

Also, it will make support, and the binary package easier to maintain bundling
the whole lot together.

My only slight concern is about changed behavior. Before your patch, as the
highest quality profile selected was the only one installed, it therefore was
used as the default profile.

With your patch, the default encoding will be the 8bit profile. My personal
feeling is that again, for support and maintainance, this is the correct
approach to follow.

However anyone who previously used a high profile at default - without
specifying it specifically in their configuration - will now have their code
changed to use the 8 bit profile. They will need to alter their config to
explicitly select the 10bit/12bit profiles as appropriate.


I'm just wondering whether this (admitedly probably rare) situation should be
warned about when a user upgrades - either via a pkg-message or an entry in
ports/UPDATING?

Cheers again! Jamie

P.S. Mikhail offered ownership of this port to me - I think instead you should
take it, if that's ok with you!

-- 
You are receiving this mail because:
You are the assignee for the bug.