[Bug 248549] x11/libX11-1.6.10,1 X Input Method connection is broken

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248549

            Bug ID: 248549
           Summary: x11/libX11-1.6.10,1   X Input Method connection is
                    broken
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: ohki at gssm.otsuka.tsukuba.ac.jp

>From libX11-1.6.10,
some X Input Method client can not connect to Input Method server.

I suspect changes of module/im/ximcp/imRmAttr.c caused the problem.
attached diff fixes the problem.

--- modules/im/ximcp/imRmAttr.c.orig    2020-08-09 16:29:11.043873000 +0900
+++ modules/im/ximcp/imRmAttr.c 2020-08-09 16:30:33.335757000 +0900
@@ -1407,8 +1407,8 @@
     *names_len = 0;
     while (total > min_len) {
        len = attr[2];
-       if (len >= (total - min_len)) {
-           return 0;
+       if (len > (total - min_len)) {
+           return 0;   /* XXX */
        }
        *names_len += (len + 1);
        len += (min_len + XIM_PAD(len + 2));

-- 
You are receiving this mail because:
You are the assignee for the bug.