[Bug 245665] multimedia/makemkv: update to 1.15.1 and allow package creation

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245665

            Bug ID: 245665
           Summary: multimedia/makemkv: update to 1.15.1 and allow package
                    creation
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: felix at palmen-it.de

Created attachment 213460
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=213460&action=edit
Update to 1.15.1, allow package creation

Upstream version 1.15.1 is available.

I need some guidance with the following things please:

1. I received a PGP signed email from the upstream author, Mike Chen, in which
he allowed to redistribute a modified makemkvcon binary for this port.
Therefore I changed the Makefile and LEGAL accordingly -- the MakeMKV EULA now
has "auto-accept" property, and I replaced RESTRICTED with NO_CDROM (as selling
a package is still forbidden) and also added LEGAL_TEXT to explain some more.
Are these changes correct, and should I provide the original email from Mike
Chen somewhere?


2. I changed a few things to satisfy portlint, but something that was a warning
before is now a fatal:

| FATAL: Makefile: LDFLAGS is already passed in CONFIGURE_ENV via bsd.port.mk.
| If you need to override the default value, alter LDFLAGS in the Makefile
| instead with LDFLAGS+=...

The override in CONFIGURE_ENV is needed to remove rpath magic added by
USE_GCC=yes, because it shouldn't be applied when cross-compiling for Linux. Is
there a better way to solve this?


Apart from these issues, the poudriere testport succeeds on my 12.1-RELEASE
amd64 and the package created works as intended. Is this enough for me to set
my maintainer-approval flag?

-- 
You are receiving this mail because:
You are the assignee for the bug.