[Bug 245466] java/java-cup: Update to 11.b.20160615, Remove BROKEN

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245466

--- Comment #4 from Edmondas Girkantas <eg at fbsd.lt> ---
Hi, thank you for submitted patch.
By some reason I was on able to apply it locally.

Few things that I would like to discuss:
1. Now this port just use prebuilt binary, is it good practice? Usually all
ports build a software from the source code.

2. Not sure regarding LICENSE, my suggestion would be to use SMLNJ license as
in lang/smlnj port.

3. I did check with portlint and changed the order of some lines.

4. CUP_VERSION placeholder in java-cup.sh.in was not replaced after
installation to proper value, so maybe we don't need that variable and just use
symlinked version ${JAVAJARDIR}/java-cup.jar?

See java-cup.diff for changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.