[Bug 240931] devel/arcanist: Exception when using with newer PHP

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240931

            Bug ID: 240931
           Summary: devel/arcanist: Exception when using with newer PHP
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: grembo at FreeBSD.org
          Reporter: lutz at donnerhacke.de
             Flags: maintainer-feedback?(grembo at FreeBSD.org)
          Assignee: grembo at FreeBSD.org

Created attachment 207953
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207953&action=edit
utils/utils.php: patch to fix call oder

Running arc on a newer version of PHP (i.e. 7.4) throws a lot of exceptions.
This is currently a cosmetic issue, but will cause real errors in the future.
```
[2019-09-30 07:00:39] ERROR 8192: implode(): Passing glue string after array is
deprecated. Swap the parameters at
[/usr/local/lib/php/libphutil/src/utils/utils.php:1706]
arcanist(), phutil()
  #0 implode(array, string) called at [<phutil>/src/utils/utils.php:1706]
  #1 phutil_build_http_querystring_from_pairs(array) called at
[<phutil>/src/utils/utils.php:1678]
  #2 phutil_build_http_querystring(array) called at
[<phutil>/src/future/http/HTTPSFuture.php:656]
  #3 HTTPSFuture::formatRequestDataForCURL() called at
[<phutil>/src/future/http/HTTPSFuture.php:280]
  #4 HTTPSFuture::isReady() called at [<phutil>/src/future/Future.php:37]
  #5 Future::resolve(NULL) called at [<phutil>/src/future/FutureProxy.php:34]
  #6 FutureProxy::resolve() called at
[<phutil>/src/conduit/ConduitClient.php:64]
  #7 ConduitClient::callMethodSynchronous(string, array) called at
[<arcanist>/src/workflow/ArcanistDiffWorkflow.php:518]
  #8 ArcanistDiffWorkflow::run() called at
[<arcanist>/scripts/arcanist.php:394]
```
The documentation in https://www.php.net/manual/en/function.implode.php says:

```
implode ( string $glue , array $pieces ) : string

Note: implode() can, for historical reasons, accept its parameters
in either order. For consistency with explode(), however, it may
be less confusing to use the documented order of arguments.
```

-- 
You are receiving this mail because:
You are the assignee for the bug.