[Bug 241928] multimedia/handbrake: fix build on GCC architectures

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241928

--- Comment #3 from Yuichiro NAITO <naito.yuichiro at gmail.com> ---
(In reply to Piotr Kubaj from comment #2)
>> Would you tell me what kind of architecture for your target?
>powerpc64

Thanks.
How about adding powerpc64 to ONLY_FOR_ARCHS?

I can't support all other architectures than amd64/i386.
Testing on powerpc64 is left to you.

>> I think it is necessary for amd64/i386 when HandBrake is built by gcc.
>amd64 and i386 on all supported releases use LLVM and I don't see any USE_GCC in the port's Makefile.

In case of CC=gcc.
Some people want to compare performance between clang and gcc.

Anyway, is it useful to you that changing your patch to following?

> LDFLAGS += $(if $(findstring gcc, $(GCC.gcc)), $(if $(findstring x86, $(GCC.archs)), $(GCC.LDFLAGS), ), )

GCC.LDFLAGS is exported if compiler is gcc and arch is x86 (includes x86_64).

-- 
You are receiving this mail because:
You are the assignee for the bug.