[Bug 241772] graphics/gdal will not compile with poppler 0.82 after update

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241772

            Bug ID: 241772
           Summary: graphics/gdal will not compile with poppler 0.82 after
                    update
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: sunpoet at FreeBSD.org
          Reporter: russo at bogodyn.org
             Flags: maintainer-feedback?(sunpoet at FreeBSD.org)
          Assignee: sunpoet at FreeBSD.org
 Attachment #208931 text/plain
         mime type:

Created attachment 208931
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208931&action=edit
Patch combining two upstream fixes to GDAL to allow it to compile with poppler
0.82

Poppler was updated a few days ago to 0.82.0, after which gdal from ports
(version 2.4.2_3) will not compile with poppler support enabled.  The specific
issue is a compilation error about two functions in pdfdataset.cpp being
declared "override" but not overriding any base class function.

Turns out this issue was addressed in GDAL's development branch specifically to
allow it to compile with poppler 0.82.0, and these fixes were also back-ported
to the 3.0 release branch, but the fix has not been backported to the branch
associated with the 2.4 version present in FreeBSD ports.  Neither has it been
back-ported to 2.5.  But the fixes are simple, are easy to find in github, are
still applicable to 2.4, and are easy to apply as a patch in the ports tree.

Commits 20c3fc7c and 94dacee in the GDAL project github repo point to the
patches needed to restore function in the FreeBSD port.  I have combined these
into the attached patch, which simply adds a const keyword in two places if and
only if poppler of a late enough version is being used.  Dropping this file
into the files directory of the gdal port restores the ability to build with
poppler.

Direct links to GDAL git commits that I combined to create this patch:
https://github.com/OSGeo/gdal/commit/20c3fc7cb4a4ec2a67642bd83ddb6e403488b0fe#diff-8c78bb6eb3e70f1b6d945c04a8f5888b
https://github.com/OSGeo/gdal/commit/94daceefebd464858888ddc85170c1a8c4bd50d7#diff-8c78bb6eb3e70f1b6d945c04a8f5888b

-- 
You are receiving this mail because:
You are the assignee for the bug.